opam: put the whole /nix in OPAM_USER_PATH_RO #57118
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comes from ocaml/opam#3773 |
Some symlinks point to /nix/var/profiles/per-user/…, these have be readable too.
umazalakain
force-pushed
the
opam-nix-user-path
branch
from
42f3f04 to
83e6a1c
Compare
umazalakain
changed the title
|
I'm also interested in making this happen. Can I help in some way to make progress on this PR? |
|
@umazalakain Thanks for the description. Am I understanding correctly that opam won't try to ever write into any of these paths? |
|
@srhb That's right, and they are mounted as read-only by bubblewrap |
|
cc @henrytill for review Barring any complaints, I don't know any good reason not to do this, but I have little experience with the ecosystem. Let's give this a week or so for review. |
|
Seems like this change was still not enough, /run/current-system/sw/lib is missing and opam won't find libraries there. This works: |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Opam uses bubblewrap to limit access to certain parts of the system. Currently, read-only access is given to
\nix/store. User installed software is found under the/home/user/.nix-profile/bincomponent of the path, however/home/user/.nix-profileitself is a symlink to/nix/var/nix/profiles/per-user/user. This results in user-installed software not being found by opam. Granting access to/nix/varby registering the whole/nixdirectory with bubblewrap solves this.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)