Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetTargetVesselPrediction #2091

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Mar 10, 2019

Fix a bug in the computation of closest approaches, and do some cleanup in Renderer and Plugin.

@@ -315,7 +302,7 @@ Renderer::Target::Target(
not_null<NavigationFrame const*> Renderer::GetPlottingFrame(
Instant const& time) const {
if (target_) {
GetTargetVesselPrediction(time);
target_->vessel->FlowPrediction(time);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not keep the check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@eggrobin eggrobin added the LGTM label Mar 10, 2019
@pleroy pleroy merged commit ab43def into mockingbirdnest:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants