Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2fsprogs: 1.44.5 -> 1.45.0 #57229

Merged
merged 2 commits into from Mar 13, 2019
Merged

e2fsprogs: 1.44.5 -> 1.45.0 #57229

merged 2 commits into from Mar 13, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 10, 2019

Motivation for this change

Changes:

Also:

  • remove 'hack' for installing pc files
  • fixup location of e2scrub_all_cron to avoid reference cycle in
    outputs, promote to $bin/bin for now.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from 7c6f434c March 12, 2019 15:55
7c6f434c
7c6f434c reviewed Mar 12, 2019
View reviewed changes
pkgs/tools/filesystems/e2fsprogs/default.nix
make install-libs
rm "$out"/lib/*.a
# avoid cycle between outputs
mv $out/lib/${pname}/e2scrub_all_cron $bin/bin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything shipped by the package use that program? That looks like a change that should break references…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't appear to be-- we don't install-crontab which would be the only reference to it AFAICT. Perhaps we could remove it but it doesn't hurt anything by keeping it either... :)

@dtzWill dtzWill merged commit 1cb7a3b into NixOS:staging Mar 13, 2019
@dtzWill dtzWill deleted the update/e2fsprogs-1.45.0 branch March 13, 2019 16:30
@dtzWill dtzWill mentioned this pull request Mar 14, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @7c6f434c @GrahamcOfBorg