Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jl: Patch to work with MonadFail GHC 8.6 change #57284

Merged
merged 1 commit into from Mar 18, 2019
Merged

jl: Patch to work with MonadFail GHC 8.6 change #57284

merged 1 commit into from Mar 18, 2019

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 10, 2019 •
edited

Motivation for this change

Patch needed until next jl is released properly.

Needs backport to 19.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb merged commit 1222e28 into NixOS:master Mar 18, 2019
srhb added a commit that referenced this pull request Mar 18, 2019
@srhb
jl: Patch to work with MonadFail GHC 8.6 change
db7dc94 
Backport of #57284
(cherry picked from commit 79e3dcb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @GrahamcOfBorg