Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GHC 8.6.4 #57282

Merged
merged 1 commit into from Mar 15, 2019
Merged

Add GHC 8.6.4 #57282

merged 1 commit into from Mar 15, 2019

Conversation

pSub
Copy link
Member

@pSub pSub commented Mar 10, 2019 •
edited

Motivation for this change

Add GHC 8.6.4 to release 19.03. This release fixes a bunch of issues (eg. haskell/haddock#979)

This PR cherry-picks commit 68be6bb.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pSub
Copy link
Member Author

pSub commented Mar 10, 2019

@GrahamcOfBorg eval

pSub referenced this pull request Mar 10, 2019
@peti
ghc: add new 8.6.4 version
68be6bb
@pSub pSub merged commit 779ef93 into release-19.03 Mar 15, 2019
@pSub pSub deleted the add-ghc-8.6.4 branch March 15, 2019 07:47
@vaibhavsagar
Copy link
Member

Can we also use the latest Stackage LTS that includes GHC 8.6.4: https://www.stackage.org/lts-13.12?

@pSub
Copy link
Member Author

pSub commented Mar 15, 2019

Sounds reasonable. @peti do you agree?

@peti
Copy link
Member

peti commented Mar 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

@kosmikus kosmikus Awaiting requested review from kosmikus

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pSub @vaibhavsagar @peti @GrahamcOfBorg