Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_0x0: init at 2018-06-24 #57135

Merged
merged 1 commit into from Mar 10, 2019
Merged

_0x0: init at 2018-06-24 #57135

merged 1 commit into from Mar 10, 2019

Conversation

ar1a
Copy link
Contributor

@ar1a ar1a commented Mar 9, 2019

Motivation for this change

With my recent contribution pb_cli out of the way, unfortunately ptpb.pw shut down last night. 0x0 is another pastebin service, and this script is a simple bash script that uploads from stdin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

7c6f434c
7c6f434c reviewed Mar 9, 2019
View reviewed changes
pkgs/tools/misc/0x0/default.nix Outdated

stdenv.mkDerivation rec {
name = "0x0-${version}";
version = "1.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't call that 1.0, to be honest; something date-based is probably more suitable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input, I've changed the version number to the date of the rev

@ar1a ar1a changed the title _0x0: init at 1.0 _0x0: init at 2018-06-24 Mar 9, 2019
@7c6f434c 7c6f434c merged commit 92537b0 into NixOS:master Mar 10, 2019
@7c6f434c
Copy link
Member

OK thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ar1a @7c6f434c @GrahamcOfBorg