Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/firewall: canonicalize ports lists #57139

Merged
merged 2 commits into from Mar 26, 2019
Merged

nixos/firewall: canonicalize ports lists #57139

merged 2 commits into from Mar 26, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Mar 9, 2019

Motivation for this change

Avoids duplicate firewall entries and makes the iptables output easier to read by having rules sorted by port number.

Used the opportunity to use types.port where applicable.

@GrahamcOfBorg test firewall

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth delroth requested a review from infinisil as a code owner March 9, 2019 19:05
@delroth delroth mentioned this pull request Mar 9, 2019
Closed
@aanderse
Copy link
Member

@GrahamcOfBorg test buildbot
Random test which uses some firewall rules.

@aanderse
Copy link
Member

Looks like buildbot is probably broken in master right now, unrelated to this. The aarch64-linux version of the test passed so that says enough for the buildbot test.

I'll run another just for fun 🤷‍♂️
@GrahamcOfBorg test samba

@matthewbauer matthewbauer merged commit d468f4b into NixOS:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@delroth @aanderse @matthewbauer @GrahamcOfBorg