Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

areca: fix build #57113

Merged
merged 1 commit into from
Mar 9, 2019
Merged

areca: fix build #57113

merged 1 commit into from
Mar 9, 2019
+4 −0

Conversation

pSub
Copy link
Member

@pSub pSub commented Mar 9, 2019 •
edited
Loading

Motivation for this change

The update to attr-2.4.48 broke the areca build (see #53716). This PR fixes the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@pSub
areca: fix build

Verified

This commit was signed with the committer’s verified signature. The key has expired.
pSub Pascal Wittmann
GPG key ID: C899ACE7E2322852
Expired
Verified
Learn about vigilant mode
13e4398
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 9, 2019
@pSub pSub merged commit d20f21d into master Mar 9, 2019
@pSub pSub deleted the fix-areca-build branch March 9, 2019 12:17
@pSub
Copy link
Member Author

pSub commented Mar 9, 2019

Cherry-picked to release-19.03 in 87321b6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pSub @GrahamcOfBorg