Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/reviewing-contributions: nix-review instead of nox-review #57076

Merged
merged 2 commits into from Mar 22, 2019
Merged

doc/reviewing-contributions: nix-review instead of nox-review #57076

merged 2 commits into from Mar 22, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 8, 2019 •
edited

It is faster, handles more edge cases and allows to test/review the built
packages interactively.

@grahamc
Copy link
Member

grahamc commented Mar 8, 2019

lgtm beyond these nits :)

@danbst
Copy link
Contributor

danbst commented Mar 9, 2019

There is one more doc file:

$ rg nox-review doc
doc/submitting-changes.xml
354:   <title>Tested compilation of all pkgs that depend on this change using <command>nox-review</command></title>
359:    can be done using the nox utility. The <command>nox-review</command>
367:<screen>nix-shell -p nox --run "nox-review wip"</screen>
372:<screen>nix-shell -p nox --run "nox-review pr 12345"</screen>

doc/reviewing-contributions.xml
197:$ nix-shell -p nox --run "nox-review -k pr PRNUMBER"

@Mic92
nix-review: 1.0.5 -> 2.0.0
eb5afaf
@Mic92
doc/reviewing-contributions: nix-review instead of nox-review
22d083e 
It is faster, handles more edge cases and allows to test/review the built
packages interactively.
@Mic92
Copy link
Member Author

Mic92 commented Mar 20, 2019

With the new release nix-review now also implements the wip subcommand and is as such a drop-in replacement for nox-review. Therefore I replaced nox-review now everywhere.

@Mic92
Copy link
Member Author

Mic92 commented Mar 20, 2019

I would also backport the new nix-review in this case to stable to have a consistent review experience for all users.

@Mic92 Mic92 merged commit 6a81a60 into NixOS:master Mar 22, 2019
@Mic92 Mic92 deleted the nix-review branch March 22, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: policy discussion 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mic92 @grahamc @danbst @worldofpeace @GrahamcOfBorg