Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better semantics for AttachFork #2087

Merged
merged 4 commits into from
Mar 9, 2019
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Mar 8, 2019

No description provided.

// at the newly-inserted point. |fork| must be a non-empty root.
// Changes |fork| to become a fork of this trajectory at the end of this
// trajectory. |fork| must be a non-empty root. It may or may not have a
// point at the same time as the end of this trajectory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify the requirements on fork that were implicit in using Append, e.g., it must not have points before the end of the trajectory, etc.

Clarify the behaviour with respect to the possible common point: which one is kept, etc.

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Mar 9, 2019
@eggrobin eggrobin merged commit b5eb045 into mockingbirdnest:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants