nixos/types: cast path
type to string, when it is "path"
#57168
Closed
+10
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This handles a specific case, when "path" type was supplied to
types.path
option. Previously it was converted into store path, because it was used
in other derivations:
So making
users.users.alice.home = /home/alice;
would convert/home/alice
directory into store path.
I can't think of situation when this is what is expected. State dirs and
password files could have been converted into store paths as well.
Having state dir on ro mount would probably result into error, but
password files were simple enough, so could easily be copied into
/nix/store
and nobody noticed.On other hand, we can't cast
types.path
to string always, becausein many places package is provided instead of path. It worked because of
silent casts... I'll leave a TODO for future contributors.
Reported in https://discourse.nixos.org/t/re-use-existing-home-migrating-from-ubuntu/2353
PS. I don't know how to write automated test for this, because it involves "paths", which are awkward to work with in a reproducible manner. I've tested locally with a local "path".
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)