Skip to content

capture: 1.0 -> 2019-03-10 #57166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2019
Merged

capture: 1.0 -> 2019-03-10 #57166

merged 1 commit into from
Mar 9, 2019
+5 −38

Conversation

ar1a
Copy link
Contributor

@ar1a ar1a commented Mar 9, 2019 •
edited
Loading

Motivation for this change

The license was recently added, see buhman/capture#6. Also, the patches were upstreamed, so they can be removed. (buhman/capture@80dd9e7)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ar1a ar1a force-pushed the capture-license branch from b3905cf to 5aafc67 Compare March 9, 2019 19:55
@ar1a ar1a changed the title capture: add gpl3Plus license capture: 1.0 -> 1.1 Mar 9, 2019
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 9, 2019
ryantm
ryantm requested changes Mar 9, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto #57167 (review)

@ar1a ar1a force-pushed the capture-license branch from 5aafc67 to d5d5bc8 Compare March 9, 2019 23:17
@ar1a
Copy link
Contributor Author

ar1a commented Mar 9, 2019

Ditto #57167 (review)

done and dusted

@ar1a ar1a force-pushed the capture-license branch from d5d5bc8 to 4263152 Compare March 9, 2019 23:22
@ryantm
Copy link
Member

ryantm commented Mar 9, 2019

@GrahamcOfBorg build capture

@ryantm ryantm changed the title capture: 1.0 -> 1.1 capture: 1.0 -> 2019-03-10 Mar 9, 2019
@ryantm ryantm merged commit 5511fd1 into NixOS:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ar1a @ryantm @GrahamcOfBorg