Feature: Railtype flags to allow/disallow 90 degree curves. #7352
+43
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
previously approved these changes
Mar 9, 2019
nielsmh
previously requested changes
Mar 9, 2019
| * @param def Default value to use if the rail type doesn't specify anything. | ||
| * @return True if 90 degree turns are allowed between the two rail types. | ||
| */ | ||
| static inline bool Rail90DegTurnDisallowed(RailType rt1, RailType rt2, bool def = _settings_game.pf.forbid_90_deg) |
There was a problem hiding this comment.
Function name says "disallowed", but doc comment says it returns true if the turn is allowed. Negative bool variables/functions are confusing in general, try to make it positive.
There was a problem hiding this comment.
Well, comment is wrong, function is right.
michicc
force-pushed
the
pr/railtype_90deg
branch
from
1a51582 to
34a92ae
Compare
PeterN
approved these changes
Mar 10, 2019
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Mar 11, 2019
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somebody apparently already declared it official; I guess I better PR it 😃
This PR allows optional NewGRF control over the state of 90 deg curves. Narrow gauge might always allow it while high-speed might never allow it, or something like that.