Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsseries: init at 1.0.5-1 #57077

Merged
merged 1 commit into from
Mar 15, 2019
Merged

dsseries: init at 1.0.5-1 #57077

merged 1 commit into from
Mar 15, 2019
+82 −0

Conversation

callahad
Copy link
Member

@callahad callahad commented Mar 8, 2019

Motivation for this change

Picking up from the ashes of #6766, this PR adds support for the Brother DSmobile scanners, including the DS-620, DS-720D, DS-820W, and DS-920DW.

It works on my machine, but there are likely ways to improve this PR. Please suggest them!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@callahad
dsseries: init at 1.0.5-1

Verified

This commit was signed with the committer’s verified signature. The key has expired.
callahad Dan Callahan
GPG key ID: 8D6DD713E9EBA7FD
Expired
Verified
Learn about vigilant mode
c80385d
@callahad callahad requested a review from infinisil as a code owner March 8, 2019 15:16
@callahad
Copy link
Member Author

callahad commented Mar 8, 2019

cc: @pjones you might be interested in this, since you originally blazed this trail

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 8, 2019
@ryantm ryantm merged commit 4b6a41a into NixOS:master Mar 15, 2019
@callahad callahad deleted the brother-dsseries branch April 23, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@callahad @ryantm @GrahamcOfBorg