Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zathura: 0.4.1 -> 0.4.3, new features and plugin #57291

Merged
merged 1 commit into from Mar 11, 2019

Conversation

jlesquembre
Copy link
Member

Update to 0.4.3, compile it with more features and add CB plugin

Motivation for this change

Update to 0.4.3, add the CB plugin and compile it with more features. I think many of the features (e.g. sqlite and manpages) where before enabled by default, but in newer releases zathura is using meson and making the features more configurable.

I commented the seccomp feature because if enabled, zathura returns an error when you try to open a link (it uses xdg-open). Not sure how to fix it, nor what seccomp does.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

seccomp allows Zathura to declare what system calls it might use, so that vulnerabilities in file format parsing become harder to exploit. I guess running xdg-open is close enough to «arbitrary execve» which is close enough to «arbitrary code execution», so the seccomp policy blocks it…

Update to 0.4.3, compile it with more features and add CB plugin
@veprbl
Copy link
Member

veprbl commented Mar 11, 2019

@GrahamcOfBorg build zathura

@7c6f434c 7c6f434c merged commit 2a41d03 into NixOS:master Mar 11, 2019
@jlesquembre jlesquembre deleted the zathura branch March 11, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants