Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-vint: Fix #57090

Merged
merged 1 commit into from Mar 8, 2019
Merged

vim-vint: Fix #57090

merged 1 commit into from Mar 8, 2019

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Mar 8, 2019 •
edited

Motivation for this change

#56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member Author

Thanks, adjusted that

worldofpeace
worldofpeace approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, I've linted a vim script.

@worldofpeace worldofpeace merged commit 9bedfe5 into NixOS:master Mar 8, 2019
@worldofpeace
Copy link
Contributor

Backported in 440c83d

@infinisil infinisil deleted the fix/vim-vint branch March 8, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infinisil @worldofpeace