Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: Makes the -dev output reproducible #57100

Merged
merged 1 commit into from
May 4, 2019
Merged

linux: Makes the -dev output reproducible #57100

merged 1 commit into from
May 4, 2019
+4 −0

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Mar 9, 2019

Motivation for this change

Makes the -dev output of the kernel reproducible.

The (temporary) file has been spotted by r13y.com

image

This file is, in turn, generated by a poor cleanup under try-run from the Makefiles. The particular one is this one:

It was found via using strace (and a good guess). The underlying cc call will call cc1 which will use -MD with the filename modified to be *.d, meaning try-run will not clean it up.

The file name is different each run, and cannot be derived. Thus the patterned rm.

Things done
  • ☑ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ☑ NixOS
  • ☑ Assured whether relevant documentation is up to date
  • ☑ Fits CONTRIBUTING.md.

cc @grahamc

grahamc
grahamc approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... :)

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 labels Mar 9, 2019
@samueldr
Copy link
Member Author

samueldr commented Mar 9, 2019

Fails with 4.20, I'm thinking they changed just enough not to be an issue.

rm: missing operand
Try 'rm --help' for more information.

@samueldr
Copy link
Member Author

samueldr commented Mar 9, 2019

With -f it will not fail on the more recent builds that seemingly don't exhibit the same issues.

@samueldr
Copy link
Member Author

samueldr commented Mar 9, 2019 •
edited
Loading

@GrahamcOfBorg build linux_latest

@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

@GrahamcOfBorg build linux_latest

@FRidh FRidh changed the base branch from master to staging April 16, 2019 17:09
@FRidh
Copy link
Member

FRidh commented Apr 16, 2019

please rebase and test again

@samueldr
Copy link
Member Author

samueldr commented Apr 17, 2019 •
edited
Loading

Just rebased, built locally.

/nix/store/nbhrlpkci5w9h0f3d82q63w1mj3h3zi9-linux-5.0.7
/nix/store/m28ljx582c75svf554xvqpbyd909jhkr-linux-4.19.34
/nix/store/i5rv0ziwb5rv5qi5a21wmnwnz191lmlc-linux-4.4.178
/nix/store/isd0ckmmwpf6ys2lks8ncxp2b4cikcpj-linux-4.14.111

Re-ran with --check and they all passed.

@FRidh FRidh merged commit e25f5c1 into NixOS:staging May 4, 2019
@samueldr samueldr deleted the r13y/linux branch May 4, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc

@thoughtpolice thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samueldr @srhb @FRidh @grahamc @GrahamcOfBorg