Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zathura-core: 0.4.1 -> 0.4.3, zathura-cb: init at 0.1.8 and refactoring #57301

Closed
wants to merge 3 commits into from
Closed

zathura-core: 0.4.1 -> 0.4.3, zathura-cb: init at 0.1.8 and refactoring #57301

wants to merge 3 commits into from

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Mar 10, 2019

Motivation for this change

This PR introduces some changes regarding the zathura document viewer.

  • zathura-core was updated to 0.4.3
  • zathura-cb was added at version 0.1.8 to add comic book support
  • zathura-pdf-mupdf's src was changed back to zathura's official URL

Each change is in its own commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Mar 10, 2019

@GrahamcOfBorg build zathura

@veprbl
Copy link
Member

veprbl commented Mar 11, 2019

First two changes are duplicate of #57291

@oxzi
Copy link
Member Author

oxzi commented Mar 11, 2019

Funny to see two PRs for an older update within one hour. Seems like I was kind of too late.
Thanks for having a look at my proposed changes.

@oxzi oxzi closed this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @veprbl @GrahamcOfBorg