Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfdump: 1.6.16 -> 1.6.17 #57306

Merged
merged 2 commits into from Apr 14, 2019
Merged

nfdump: 1.6.16 -> 1.6.17 #57306

merged 2 commits into from Apr 14, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Mar 10, 2019

Motivation for this change
Things done

Also enabled the build of a few additional tools.
Closure size increases from 33.8M to 35.0M.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tobim
nfdump: 1.6.16 -> 1.6.17
9b5f657 
Build system switched to autotools in the new version.
Also enabled the build of a few additional tools.
markuskowa
markuskowa requested changes Apr 13, 2019
View reviewed changes
pkgs/tools/networking/nfdump/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/nfdump/default.nix Show resolved Hide resolved
@markuskowa
Copy link
Member

Changelog: https://github.com/phaag/nfdump/releases

@tobim
Cleanup
e08c2db 
- Remove unneeded call to patchShebangs
- Add a comment explaining the darwin libtoolize workaround
@markuskowa markuskowa merged commit 674d7f4 into NixOS:master Apr 14, 2019
@tobim tobim deleted the nfdump-1.6.17 branch March 17, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tobim @markuskowa @infinisil @GrahamcOfBorg