Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proot: update, consolidate, python extension support #57195

Merged
merged 2 commits into from Mar 11, 2019
Merged

proot: update, consolidate, python extension support #57195

merged 2 commits into from Mar 11, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 10, 2019

Motivation for this change
  • Commits in update: proot-me/proot@11972c0...ff61c86
  • Consolidate by using single version of proot regardless, aarch64 works now
    • Tested on aarch64 box
  • minor cleanup
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Mar 11, 2019

I've tested on RHEL7 and there are multiple regressions: -0 and -k options don't work. This is not a happening on NixOS though, so I guess this is okay to merge.

@veprbl veprbl merged commit 2274611 into NixOS:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl Awaiting requested review from veprbl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @veprbl @GrahamcOfBorg