Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yubioath-desktop: prefix QML2_IMPORT_PATH #57122

Merged
merged 1 commit into from Mar 10, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 9, 2019

Otherwise, yubioath-desktop can't find pyothersides qml files:

QQmlApplicationEngine failed to load component
qrc:/qml/main.qml:168 Type YubiKey unavailable
qrc:/qml/YubiKey.qml:2 module "io.thp.pyotherside" is not installed

[1] 17017 segmentation fault result/bin/yubioath-desktop

Motivation for this change

I wasn't able to run yubioath-desktop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Otherwise, yubioath-desktop can't find pyothersides qml files:

QQmlApplicationEngine failed to load component
qrc:/qml/main.qml:168 Type YubiKey unavailable
qrc:/qml/YubiKey.qml:2 module "io.thp.pyotherside" is not installed

[1]    17017 segmentation fault  result/bin/yubioath-desktop
@flokli
Copy link
Contributor Author

flokli commented Mar 9, 2019

@samueldr , @ttuegel: If I got it right, qml file loading seems to be adressed in #54525 as well, but not in #44047, right?

@Mic92
Copy link
Member

Mic92 commented Mar 10, 2019

Was this also a problem, when you install the application in your profile?

@Mic92 Mic92 merged commit f982aa0 into NixOS:master Mar 10, 2019
@flokli
Copy link
Contributor Author

flokli commented Mar 10, 2019

@Mic92 no, that only happened when building separately via nix-build, and then calling from the nix store. Still, I often use that to try out applications.

Could you backport this to 19.03 and 18.09 too?

@flokli flokli deleted the yubioath-desktop-qml2 branch March 10, 2019 11:59
@flokli
Copy link
Contributor Author

flokli commented Mar 10, 2019

backported to 19.03 in 5087648.

18.09 is still on 3.1.0, which seems to be much older (more Python and less QT, not using pyotherside at all) - so it's not affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants