Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update php packages #57066

Merged
merged 3 commits into from Mar 11, 2019
Merged

Update php packages #57066

merged 3 commits into from Mar 11, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Mar 8, 2019 •
edited

Motivation for this change

Update php packages to version 7.1.27, 7.2.16 and 7.3.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor

etu commented Mar 8, 2019

Changelogs:
http://www.php.net/ChangeLog-7.php#7.1.27
http://www.php.net/ChangeLog-7.php#7.2.16
http://www.php.net/ChangeLog-7.php#7.3.3

PHP should usually be backported to stable, so if you wish to create backport PR's for the 19.03 and 18.09 branch that would be great :-)

@etu
Copy link
Contributor

etu commented Mar 8, 2019

@GrahamcOfBorg build php71 php72 php73

@GrahamcOfBorg GrahamcOfBorg requested review from etu and globin March 8, 2019 07:40
@etu
Copy link
Contributor

etu commented Mar 8, 2019

@Izorkin Maybe focus at the task at hand for this PR? Only the update and make sure that works? Options sure are great, but it's a separate PR.

@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 8, 2019

@GrahamcOfBorg build php73

@etu
Copy link
Contributor

etu commented Mar 8, 2019

@GrahamcOfBorg build php73-embed php73

@etu
Copy link
Contributor

etu commented Mar 11, 2019

php73 just did build on #57361 on darwin. So I'll go ahead and merge this.

@etu etu merged commit eeecb9d into NixOS:master Mar 11, 2019
@etu etu mentioned this pull request Mar 11, 2019
Closed
@Izorkin Izorkin deleted the php branch March 11, 2019 12:39
This was referenced Mar 14, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin globin is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @etu @fpletz @GrahamcOfBorg