Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cheat: 2.3.1 -> 2.5.1 #57064

Merged
merged 1 commit into from Mar 8, 2019
Merged

cheat: 2.3.1 -> 2.5.1 #57064

merged 1 commit into from Mar 8, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 8, 2019

Motivation for this change

The other upgrade broke cheat as no internal cheatsheats where found.
Now it works again.
cc @BadDecisionsAlex

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 1b83302 into NixOS:master Mar 8, 2019
@Mic92 Mic92 deleted the cheat branch March 8, 2019 10:53
@Mic92 Mic92 mentioned this pull request Mar 8, 2019
10 tasks
@aakropotkin
Copy link
Contributor

Hey just a heads up. In the 2.3.1 the default sheets were excluded so i wanted to remain consistent.
The rationale is that a user cannot append or edit those sheets using cheat -e foo because they will be readonly in the store.
I think a good solution might be issuing a message when the program is installed to let folks know to redirect their cheat path to something local, .local/share/cheat for instance, or to put the default sheets there as a sane default.

In any case thank you for raising the issue. I appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants