Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errbot: fix broken dependencies #57256

Merged
merged 4 commits into from Mar 23, 2019
Merged

errbot: fix broken dependencies #57256

merged 4 commits into from Mar 23, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 10, 2019 •
edited

Motivation for this change

This PR aims to fix several dependencies of errbot that were broken recently.
Each commit fixes a broken dependencies, further details are in the commit message's body.

Addresses #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
pythonPackages.jaraco_itertools: fix build
eede376 
The package currently fails because of some flake8 violations. However
invalid coding style shouldn't break the Nix package.

See also https://hydra.nixos.org/build/90115508
Addresses NixOS#56826
@Ma27
pythonPackages.jaraco_text: 2.0 -> 3.0
4c57b5e 
This fixes the dependency cycle between `jaraco_text` and
`jaraco_collections`. Reported upstream in jaraco/jaraco.text#3

See also https://hydra.nixos.org/build/90307068
See also https://hydra.nixos.org/build/90310398
Addresses NixOS#56826
@Ma27
pythonPackages.jaraco_logging: fix build
18b0729 
The package currently fails because of some flake8 violations. However
invalid coding style shouldn't break the Nix package.

See also https://hydra.nixos.org/build/90301692
Addresses NixOS#56826
@Ma27
python3Packages.irc: fix build
8159a1f 
Adds missing `jaraco_collections` dependency. This also unbreaks
`errbot`.

See also https://hydra.nixos.org/build/90116401
Addresses NixOS#56826
@Ma27 Ma27 requested a review from FRidh as a code owner March 10, 2019 15:51
@Ma27
Copy link
Member Author

Ma27 commented Mar 10, 2019 •
edited

Currently running nix-review locally, will report back and fix further packages if this breaks something.

EDIT: done

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 23, 2019
@dotlambda dotlambda merged commit 3f217df into NixOS:master Mar 23, 2019
@dotlambda
Copy link
Member

backported in 105d99a..16516df

@Ma27 Ma27 deleted the fix-jaraco-pkgs branch March 23, 2019 18:10
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @dotlambda @samueldr @GrahamcOfBorg