pythonPackages.rbtools: fix tests #57258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| propagatedBuildInputs = [ six ]; | ||
|
|
||
| checkPhase = "nosetests"; | ||
| checkPhase = "LC_ALL=C nosetests"; |
There was a problem hiding this comment.
Why was setting LC_ALL needed?
We have 1fccd25
There was a problem hiding this comment.
A test failed without it:
running install tests
..........E..........................SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS.................SSSSSSSSSSSSSSSSSSS...............
======================================================================
ERROR: Testing the cache with the Expires header in the future
----------------------------------------------------------------------
Traceback (most recent call last):
File "/build/RBTools-0.7.2/rbtools/api/tests.py", line 782, in test_expires_header_future
locale.resetlocale(locale.LC_TIME)
File "/nix/store/ih03q5vi6kj278l4jk4kh41lqyagzzdi-python-2.7.15/lib/python2.7/locale.py", line 591, in resetlocale
_setlocale(category, _build_localename(getdefaultlocale()))
Error: unsupported locale setting
When I run it with "LC_ALL=C.UTF-8 nosetests" it fails, with LC_ALL=C it doesn't. I have no idea why.
|
@GrahamcOfBorg build python27Packages.rbtools |
|
needs backport to 19.03, /cc #56826 |
xeji
pushed a commit
that referenced
this pull request
Mar 12, 2019
(cherry picked from commit 382abc9)
|
picked to 19.03 in c4f45df |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
rbtools was broken, in the checkPhase it could not find the
nosetestsexecutable.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)