Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoneminder: Fix database name and username #57125

Merged
merged 1 commit into from Mar 9, 2019
Merged

zoneminder: Fix database name and username #57125

merged 1 commit into from Mar 9, 2019

Conversation

amazari
Copy link
Contributor

@amazari amazari commented Mar 9, 2019

Motivation for this change

PR #56889 messed up db and use naming while fixing the scope of the initialDatabases property.
This patch fixes the issue.

Things done

Invert the values of ZM_DB_NAME and ZM_DB_USERNAME that were previously messed up.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@amazari
zonminder: Fix database name and username
56aa491 
PR NixOS#56889 messed up db and use naming while fixing the scope of the initialDatabases property.
This patch fixes the issue.
@amazari amazari requested a review from infinisil as a code owner March 9, 2019 16:25
@amazari amazari mentioned this pull request Mar 9, 2019
Merged
10 tasks
@7c6f434c 7c6f434c merged commit ea32c78 into NixOS:master Mar 9, 2019
@danbst
Copy link
Contributor

danbst commented Mar 9, 2019

huh, thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amazari @danbst @7c6f434c @GrahamcOfBorg