Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pyext: 0.6 -> 0.8 #57128

Merged
merged 1 commit into from Mar 9, 2019
Merged

Conversation

FlorianFranzen
Copy link
Contributor

Motivation for this change

Updates pyext to the latest version.

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Attribute in the commit msg should be pythonPackages or python.pkgs.

Generally pythonPackages is preferred though.

@FlorianFranzen FlorianFranzen changed the base branch from master to staging-next March 9, 2019 19:22
@FlorianFranzen
Copy link
Contributor Author

@worldofpeace Thank you for your feedback, just uploaded all the proposed changes and change the target branch to staging-next, because of the large number of rebuilds.

@worldofpeace
Copy link
Contributor

@worldofpeace Thank you for your feedback, just uploaded all the proposed changes and change the target branch to staging-next, because of the large number of rebuilds.

And thank you for responding well.

However, we don't usually merge a change into staging-next unless it explicitly stabilizes it so it can be promoted to master.
Also think the rebuilds are just from pythonPackages.protobuf and python packages build quick, so this can go to master.

@FlorianFranzen FlorianFranzen changed the base branch from staging-next to master March 9, 2019 19:39
@FlorianFranzen
Copy link
Contributor Author

I see, somehow i thought the order was staging-next -> staging, not the other way around. Anyhow, I change it back to master.

@worldofpeace
Copy link
Contributor

I see, somehow i thought the order was staging-next -> staging, not the other way around. Anyhow, I change it back to master.

Yeah, I understand your confusion there, as we don't have it formally documented.

Only explaination we have currently would be is the RFC.

@worldofpeace worldofpeace merged commit 7435c63 into NixOS:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants