Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.xattr: fix build with attr-2.4.48 (see #53716) #57129

Merged
merged 1 commit into from Mar 15, 2019
Merged

haskellPackages.xattr: fix build with attr-2.4.48 (see #53716) #57129

merged 1 commit into from Mar 15, 2019

Conversation

pSub
Copy link
Member

@pSub pSub commented Mar 9, 2019 •
edited

Motivation for this change

Fixes the build with attr-2.4.48 (see #53716). I've submitted with patch (deian/libattr-hs#3) to upstream as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pSub
Copy link
Member Author

pSub commented Mar 9, 2019

This patch needs to be backported to 19.03 as well.

@pSub pSub changed the title haskellPackages.xattr: fix build with attr-2.4.48 (see ##53716) haskellPackages.xattr: fix build with attr-2.4.48 (see #53716) Mar 15, 2019
@pSub
Copy link
Member Author

pSub commented Mar 15, 2019

@GrahamcOfBorg build haskellPackages.xattr

@pSub pSub merged commit 66504c0 into master Mar 15, 2019
@pSub pSub deleted the fix-haskellPackages-xattr branch March 15, 2019 08:08
@pSub
Copy link
Member Author

pSub commented Mar 15, 2019

Cherry-picked to 19.03 in 009976d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pSub @GrahamcOfBorg