Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sublime3: fix icon #57130

Closed
wants to merge 1 commit into from
Closed

sublime3: fix icon #57130

wants to merge 1 commit into from

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 9, 2019

Motivation for this change

GNOME Shell no longer showed icon of Sublime Text for me,
nixos-rebuild switch with this followed by touching ~/.local/share/icons
fixed it.

Perhaps the icon cache introduced in #48116 excludes /share/icons?

cc @hedning @romildo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
sublime3: fix icon
8278eec 
GNOME Shell no longer showed icon of Sublime Text for me,
nixos-rebuild switch with this followed by touching ~/.local/share/icons
fixed it.
@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 9, 2019 •
edited

Yeah, gtk.iconCache.enable = false; fixes the Sublime Text icon but breaks most of others.

@jtojnar jtojnar mentioned this pull request Mar 9, 2019
Open
@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 9, 2019

We need a more systemic solution, I opened an issue #57134

@jtojnar jtojnar closed this Mar 9, 2019
@jtojnar jtojnar deleted the sublime-icon branch March 9, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens Awaiting requested review from wmertens

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg