Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: windowshade for rail station construction window #7341

Conversation

andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Mar 8, 2019

Rationale for this:

  • I run OpenTTD at 2x UI zoom in a 13" screen
  • I use newgrf stations
  • The station construction window always fills most of the viewport, obscuring the map where I want to build
  • I have to drag the station window, which puts it mostly out of the viewport, then drag it back if I want to change station tile or orientation
  • windowshade is established in OpenTTD and is more convenient than dragging the window around

There is a movie of the problem here: https://dev.openttdcoop.org/attachments/download/8265/building_stations.mov (76MB, H264, but .mov format sorry).

@andythenorth
Copy link
Contributor Author

shade_rail_station_selection

src/rail_gui.cpp Outdated
this->coverage_height += top - bottom;
this->ReInit();
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation, use tabs not spaces.

src/rail_gui.cpp Outdated Show resolved Hide resolved
@PeterN PeterN changed the title Change: add windowshade to rail station construction window Change: Add windowshade to rail station construction window Mar 8, 2019
@michicc
Copy link
Member

michicc commented Mar 8, 2019

Add: Windowshade...

Change: should be the last resort commit message tag, no the first choice like it seems to become.

@andythenorth andythenorth force-pushed the windowshade-rail-station-construction-window branch from 6c0554a to b67a8ed Compare March 9, 2019 08:14
@andythenorth andythenorth changed the title Change: Add windowshade to rail station construction window Add: windowshade for rail station construction window Mar 9, 2019
@andythenorth andythenorth force-pushed the windowshade-rail-station-construction-window branch 4 times, most recently from d9a2b16 to 971ae6e Compare March 9, 2019 10:40
@andythenorth andythenorth force-pushed the windowshade-rail-station-construction-window branch from 971ae6e to 1704d3b Compare March 9, 2019 10:45
@PeterN PeterN merged commit 46aca93 into OpenTTD:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants