websocat: init at 1.3.0 #57211
Closed
websocat: init at 1.3.0 #57211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Seipp <aseipp@pobox.com>
srhb
reviewed
Mar 10, 2019
| src = fetchFromGitHub { | ||
| owner = "vi"; | ||
| repo = "websocat"; | ||
| rev = "refs/tags/v${version}"; |
There was a problem hiding this comment.
Suggested change
| rev = "refs/tags/v${version}"; | |
| rev = "v${version}"; |
... alternatively an explanatory comment for why the release tarball doesn't work? :)
There was a problem hiding this comment.
No, I simply always use refs/tags -- I was under the impression there's no difference, i.e. that fetchFromGitHub always acquires an archive tarball of some tree snapshot, though I might obviously wrong about that.
There was a problem hiding this comment.
No, you're right and I'm wrong. Thanks. :)
srhb
approved these changes
Mar 10, 2019
|
Closed in 37fe6bf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
sandboxinnix.confon non-NixOS)./result/bin/)