Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omnisharp-roslyn: init at 1.32.8 #57205

Merged
merged 1 commit into from Apr 27, 2019
Merged

omnisharp-roslyn: init at 1.32.8 #57205

merged 1 commit into from Apr 27, 2019

Conversation

tesq0
Copy link
Contributor

@tesq0 tesq0 commented Mar 10, 2019

Motivation for this change

Intellisense for c#

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed Mar 23, 2019
View reviewed changes
Copy link
Contributor

@joachifm joachifm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

pkgs/development/tools/omnisharp-roslyn/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/omnisharp-roslyn/default.nix Outdated Show resolved Hide resolved
@billksun
Copy link
Contributor

billksun commented Apr 1, 2019

Would this resolve #44999 when specifying to use the Nix package installation?

@tesq0
Copy link
Contributor Author

tesq0 commented Apr 2, 2019

@sib-null Yes, it would.
You would need to add this to your settings.json in vscode:
"omnisharp.path": "full/path/to/omnisharp" (like "/home/someuser/.nix-profile/bin/omnisharp")

@billksun
Copy link
Contributor

billksun commented Apr 9, 2019

Can this be merged?

@mattywillo
Copy link

Using this with

"omnisharp.path": "/run/current-system/sw/bin/omnisharp"

In vscode is working fine, seems like it could be merged?

@joachifm joachifm merged commit 357df76 into NixOS:master Apr 27, 2019
@billksun billksun mentioned this pull request Sep 26, 2019
Closed
@stanipintjuk stanipintjuk mentioned this pull request Oct 29, 2019
Closed
@Philipp-M Philipp-M mentioned this pull request Aug 26, 2020
Merged
@oakular oakular mentioned this pull request Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tesq0 @billksun @mattywillo @joachifm @GrahamcOfBorg