Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk3: Fix for missing symbols (again) #57095

Merged
merged 1 commit into from Mar 9, 2019
Merged

gtk3: Fix for missing symbols (again) #57095

merged 1 commit into from Mar 9, 2019

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Mar 8, 2019 •
edited

Was removed again in f9a62db, but it
was still needed after all, see #55692 (comment)

Fixes #55692 and possibly lots of haskell packages with it, certainly taffybar

Ping @vcunat @jtojnar @dtzWill

Motivation for this change

#56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

7c6f434c commented Mar 9, 2019

Darwin failure is a transient builder resource exhaustion, apparently.

@infinisil
gtk3: Fix for missing symbols (again)
e0cc49c 
Was removed again in f9a62db, but it
was still needed after all, see NixOS#55692 (comment)
@infinisil infinisil changed the base branch from master to staging March 9, 2019 14:49
@infinisil infinisil merged commit 3ea5f97 into NixOS:staging Mar 9, 2019
@infinisil
Copy link
Member Author

Cherry-picked to staging-19.03 in 6607b8e

@infinisil infinisil deleted the fix/gtk3-symbols branch March 9, 2019 16:31
vcunat pushed a commit that referenced this pull request Mar 10, 2019
@infinisil @vcunat
Merge #57095: gtk3: Fix for missing symbols (again)
2206a3e 
(cherry picked from commit 3ea5f97)
Forward-picking from staging to staging-next.  It seems quite
an important fix with little risk of breakage, and it isn't such a huge
rebuild, especially considering the unfinished amount on staging-next ATM.
@dtzWill
Copy link
Member

dtzWill commented Mar 11, 2019 via email

@infinisil infinisil mentioned this pull request Apr 11, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@infinisil @7c6f434c @dtzWill @GrahamcOfBorg