Bonnie 1.98 #57232
Merged
Bonnie 1.98 #57232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version is already available in debian testing.
The bon_csv2txt utility is a perl script. By default it is looking forbonnie: fix bon_csv2txt utility The bon_csv2txt utility is a perl script. By default it is looking for perl in /usr/bin/perl which doesn't work on nixos. This changes patches the perl interpreter correctly. But this comes as at a cost of closure size increase from 34'006'536 bytes to 90'289'456 bytes as perl is now a dependency. An alterantive would be to patch the file to use /usr/bin/env perl and just rely on a perl interpreter being present in PATH. perl in /usr/bin/perl which doesn't work on nixos. This changes patches the perl interpreter correctly. But this comes as at a cost of closure size increase as perl is now a dependency. An alterantive would be to patch the file to use /usr/bin/env perl and just rely on a perl interpreter being present in PATH.
|
I think the closure increase is absolutely sane in this case, because perl is a true runtime dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest version:
https://metadata.ftp-master.debian.org/changelogs//main/b/bonnie++/bonnie++_1.98_changelog
Make the
bon_csv2txtuntility work. It is a perl script and thus requires the correct perl interpreter.Closure size increased from 34'006'536 bytes to 90'289'456 due to perl.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)