Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Add flag and railtype sprite type to draw pre-combined ground sprites. #7231

Merged
merged 1 commit into from Mar 9, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Feb 14, 2019

This allows a NewGRF rail type to provide all combinations of track junctions itself, in case the default method of overlaying parts is unsatisfactory. This is an all-or-nothing flag, so all combinations must be provided if set.

This is a feature possibly requested long ago. It has not been tested and as far as I know no test-case currently exists.

@PeterN PeterN added wip Work in progress. Feature branch that will require feedback during the development process and removed wip Work in progress. Feature branch that will require feedback during the development process labels Feb 14, 2019
@PeterN
Copy link
Member Author

PeterN commented Feb 21, 2019

This is not a WIP, however it would need to be confirmed by testing.

@andythenorth andythenorth added the component: NewGRF This issue is related to NewGRFs label Mar 2, 2019
@PeterN PeterN marked this pull request as ready for review March 7, 2019 19:29
Copy link
Member

@michicc michicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea if it's feasible in practice to make sprites for this, but the code looks sound.

@PeterN
Copy link
Member Author

PeterN commented Mar 8, 2019

Mmm, it's simply 63 sprites for all-but-one combinations. I'll try cobbling something together.

@PeterN PeterN merged commit 42046af into OpenTTD:master Mar 9, 2019
@PeterN PeterN deleted the railtype-nocombine branch March 9, 2019 02:53
@andythenorth
Copy link
Contributor

This or similar was requested by Pikka for #5132

@PeterN
Copy link
Member Author

PeterN commented Mar 9, 2019

I spoke to another author recently who also expressed interest in this feature, so I made a test NewGRF. Wiki has been updated as well.

nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants