Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ephemeral: init at 4.2.0 #57246

Closed
wants to merge 1 commit into from
Closed

ephemeral: init at 4.2.0 #57246

wants to merge 1 commit into from

Conversation

xiorcale
Copy link
Contributor

Motivation for this change

Browse the web more privately with the pantheon desktop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

hicolor-icon-theme
libgee
pantheon.granite
python3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure we only need this in nativeBuildInputs so patchShebangs can give right python executable path in the post_install.py.

@xiorcale xiorcale closed this May 17, 2019
@worldofpeace
Copy link
Contributor

Did you mean to close this @Kjuvi?

@xiorcale
Copy link
Contributor Author

xiorcale commented May 18, 2019

I had totally messed up my fork and in the doubt removed this related PR, but I can open a new one and finally finish it

(here it is: ephemeral 5.1.0)

@xiorcale xiorcale mentioned this pull request May 18, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants