Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php: add custom options #57245

Merged
merged 1 commit into from Mar 14, 2019
Merged

php: add custom options #57245

merged 1 commit into from Mar 14, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Mar 10, 2019

Motivation for this change

Add to php build options with re2c and valgrind.
Fixed this configure warning:

configure: WARNING: You will need re2c 0.13.4 or later if you want to regenerate PHP parsers.

and

checking for the location of zlib... /nix/store/ww7601vx7qrcwwfnwzs1cwwx6zcqdjz3-zlib-1.2.11-dev
configure: WARNING: ========================================================
configure: WARNING: Use of bundled libzip is deprecated and will be removed.
configure: WARNING: Some features such as encryption and bzip2 are not available.
configure: WARNING: Use system library and --with-libzip is recommended.
configure: WARNING: ========================================================

cc @etu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 10, 2019

@GrahamcOfBorg build php71 php72 php73

@etu
Copy link
Contributor

etu commented Mar 11, 2019

@GrahamcOfBorg build php71 php72 php73

Building again since php was updated in master.

@etu etu merged commit 894eee6 into NixOS:master Mar 14, 2019
@Izorkin Izorkin deleted the php-options branch March 14, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants