Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unity3d: 2017.4.10f1 -> 2018.3.0f2 #57201

Merged
merged 3 commits into from Apr 11, 2019
Merged

unity3d: 2017.4.10f1 -> 2018.3.0f2 #57201

merged 3 commits into from Apr 11, 2019

Conversation

tesq0
Copy link
Contributor

@tesq0 tesq0 commented Mar 10, 2019

Motivation for this change

Allow people to use a newer version of unity on nixos

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x] Assured whether relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 10, 2019

@GrahamcOfBorg build unity3d

timokau
timokau requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the team! Please reorder your commits (currently the first commit fails to evaluate since you added yourself to the maintainer list of the package before declaring yourself as a maintainer). Also split the update commit into two, one adding yourself to the maintainer list and one updating the package. The resulting commits should be:

  1. maintainers: add tesq0
  2. unity3d: add tesq0 to the maintainers
  3. unity3d: 2017.4.10f1 -> 2018.3.0f2

@tesq0
Copy link
Contributor Author

tesq0 commented Apr 11, 2019

@timokau Should be good now

timokau
timokau approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@timokau timokau merged commit 0550927 into NixOS:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tesq0 @ryantm @timokau @infinisil @GrahamcOfBorg @Janik-Haag