Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

folly: build and run tests #57220

Closed
wants to merge 1 commit into from
Closed

folly: build and run tests #57220

wants to merge 1 commit into from

Conversation

strager
Copy link
Contributor

@strager strager commented Mar 10, 2019 •
edited

Motivation for this change

Make it easier to catch possible misconfiguration and regressions for the folly package by running folly's test suite.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@strager strager marked this pull request as ready for review March 12, 2019 04:57
@strager
folly: build and run tests
bcec9e6 
Make it easier to catch possible misconfiguration and regressions for the
folly package by running folly's test suite.
@strager
Copy link
Contributor Author

strager commented Apr 29, 2019

Superseded by #59846.

@strager strager closed this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@strager @GrahamcOfBorg