Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs_{6,8,10,11}_x: update, security fixes #57074

Merged
merged 4 commits into from Mar 13, 2019
Merged

nodejs_{6,8,10,11}_x: update, security fixes #57074

merged 4 commits into from Mar 13, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 8, 2019

Motivation for this change
  • backport please
  • I don't think these are auto-updated, not sure why.
    If there's something making auto-update difficult,
    it may be worth investigating why (if anyone knows please share :)).
Things done
  • [x]] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir andir added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 8, 2019
@andir
Copy link
Member

andir commented Mar 8, 2019

looks good so far. maxima fails to build:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/b5vw1xsm1m61872lfc1l3v258rfq92jh-maxima-5.42.2.tar.gz
source root is maxima-5.42.2
setting SOURCE_DATE_EPOCH to timestamp 1548179401 of file maxima-5.42.2/interfaces/xmaxima/doc/xmaxima_toc.html
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
applying patch /nix/store/2pwmmwn3v4nw3r2apmzlvbl2bfy8pan7-infodir.patch?id=07d6c37d18811e2b377a9689790a7c5e24da16ba
patching file src/init-cl.lisp
applying patch /nix/store/3gsp39bvn1mn0jid96ayfhw1hxfq09qq-matrixexp.patch?id=07d6c37d18811e2b377a9689790a7c5e24da16ba
patching file share/linearalgebra/matrixexp.lisp
applying patch /nix/store/0xfa805ac0xpgfn8rk2l6faw66ywpiff-undoing_true_false_printing_patch.patch?id=07d6c37d18811e2b377a9689790a7c5e24da16ba
patching file src/grind.lisp
applying patch /nix/store/fk5sgpnc8fg55zah4d39dnkhhdhmm8s0-0001-taylor2-Avoid-blowing-the-stack-when-diff-expand-isn.patch?id=07d6c37d18811e2b377a9689790a7c5e24da16ba
patching file src/hayat.lisp
Hunk #1 succeeded at 2190 (offset 1 line).
Hunk #2 succeeded at 2250 (offset 1 line).
Hunk #3 succeeded at 3009 (offset 1 line).
applying patch /nix/store/80yz16jiyq1mb85a62k8rndlsm1cw2cb-maxima.system.patch?id=07d6c37d18811e2b377a9689790a7c5e24da16ba
patching file src/maxima.system
applying patch /nix/store/6mgci163mj7nwzspwmvmvxc4lcnrmwvj-known-ecl-failures.patch
patching file tests/testsuite.lisp
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file tests/testsuite.lisp.rej

Still rebuilding all of the other packages.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 12, 2019

Patch failure seems unrelated, or does it somehow use the nodejs sources or something? (does maxima fail before these updates?)

@andir
Copy link
Member

andir commented Mar 13, 2019

According to hydra it does not fail: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.maxima.x86_64-linux

But it is probably no reason to not merge this. I do not see how they both are related. I think at the time I used nix-review pr ... and that also tried to build maxima. It seems to work just fine now.

@andir andir merged commit a09281e into NixOS:master Mar 13, 2019
This was referenced Mar 13, 2019
Merged
Merged
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @andir @marsam @samueldr @GrahamcOfBorg