Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strongswan: 5.7.1 -> 5.7.2 #57072

Merged
merged 2 commits into from Mar 8, 2019
Merged

strongswan: 5.7.1 -> 5.7.2 #57072

merged 2 commits into from Mar 8, 2019

Conversation

knl
Copy link
Contributor

@knl knl commented Mar 8, 2019 •
edited

Motivation for this change

The new update is out since December 2018, and it brings in many nice changes and improvements.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knl
Copy link
Contributor Author

knl commented Mar 8, 2019

Builds on my machine:

$(nix-build -A strongswan --argstr system x86_64-darwin)/bin/ipsec --version
Darwin strongSwan U5.7.2/K18.2.0
University of Applied Sciences Rapperswil, Switzerland
See 'ipsec --copyright' for copyright information.

@basvandijk
Copy link
Member

@GrahamcOfBorg test strongswan-swanctl

@basvandijk
Copy link
Member

basvandijk commented Mar 8, 2019 •
edited

@knl can you test if basvandijk@4dd1329 fixes the strongswan-swanctl test? I don't have access to a Linux build machine at the moment so I can't test this myself. Thanks.

@knl knl force-pushed the upgrade-strongswan-5.7.2 branch from 6998455 to e44e245 Compare March 8, 2019 15:11
@knl knl requested a review from infinisil as a code owner March 8, 2019 15:11
@basvandijk
Copy link
Member

@GrahamcOfBorg test strongswan-swanctl

@basvandijk basvandijk self-requested a review March 8, 2019 15:15
@knl
Copy link
Contributor Author

knl commented Mar 8, 2019 •
edited

@basvandijk tested, it seems to be working (exit code 0):

...
carol: exit status 1
(10.03 seconds)
carol: running command: ping -c 1 alice
carol: exit status 0
(0.02 seconds)
(23.09 seconds)
(23.53 seconds)
collecting coverage data
carol: running command: test -e /sys/kernel/debug/gcov
carol: exit status 1
(0.00 seconds)
(0.00 seconds)
syncing
carol: running command: sync
carol: exit status 0
(0.11 seconds)
(0.11 seconds)
test script finished in 23.64s
cleaning up
killing carol (pid 595)
killing moon (pid 607)
killing alice (pid 619)
(0.00 seconds)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: vde_switch: Could not remove ctl dir '/build/vde0.ctl': Directory not emptyCould not remove ctl dir '/build/vde1.ctl': Directory not empty

copying 1 paths...
copying path '/nix/store/5qidr5jch0v6cfrm9wb7wrn2nvymsxpx-vm-test-run-strongswan-swanctl' from 'ssh://nixBuild@192.168.100.150'...
/nix/store/5qidr5jch0v6cfrm9wb7wrn2nvymsxpx-vm-test-run-strongswan-swanctl

@basvandijk
Copy link
Member

Thanks, will merge after ofborg is happy.

@knl
Copy link
Contributor Author

knl commented Mar 8, 2019

That's always the best strategy :)

@basvandijk basvandijk merged commit 6b9d8a2 into NixOS:master Mar 8, 2019
@knl knl deleted the upgrade-strongswan-5.7.2 branch March 8, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk basvandijk approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knl @basvandijk @GrahamcOfBorg