Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch-github: 2.1 -> 2.2 #57084

Merged
merged 1 commit into from
Mar 12, 2019
Merged

nix-prefetch-github: 2.1 -> 2.2 #57084

merged 1 commit into from
Mar 12, 2019
+2 −2

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Mar 8, 2019 •
edited
Loading

Motivation for this change

This is a backport from master/unstable. Release 2.1 of nix-prefetch-github contains a bug and version 2.2 is 100% backwards compatible with version 2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Mar 8, 2019
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 8, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build nix-prefetch-github

worldofpeace
worldofpeace suggested changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seppeljordan You need to use git cherry-pick -xe with the commit from master.

@seppeljordan seppeljordan force-pushed the update-nix-prefetch-github branch from d27ce17 to debd6a6 Compare March 12, 2019 01:12
@seppeljordan
nix-prefetch-github: 2.1 -> 2.2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
57e525e 
(cherry picked from commit b0e63ad)
@seppeljordan seppeljordan force-pushed the update-nix-prefetch-github branch from debd6a6 to 57e525e Compare March 12, 2019 01:13
@seppeljordan
Copy link
Contributor Author

@worldofpeace okay. I did so. please let me know if there is more to be changed about this PR.

@worldofpeace worldofpeace merged commit 6c33f9f into NixOS:release-19.03 Mar 12, 2019
@worldofpeace
Copy link
Contributor

@worldofpeace okay. I did so. please let me know if there is more to be changed about this PR.

Everything looked great. Thanks for keeping track of your software in nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seppeljordan @worldofpeace @GrahamcOfBorg