Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] nix: 2.1.3 -> 2.2 #57094

Closed
wants to merge 1 commit into from
Closed

[18.09] nix: 2.1.3 -> 2.2 #57094

wants to merge 1 commit into from

Conversation

matthewbauer
Copy link
Member

Updates nix to 2.2 on release-18.09. Contains fixes for things like NixOS/nix#2715.

(cherry picked from commit 94ea1c2)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edolstra @matthewbauer
nix: 2.1.3 -> 2.2
a994a6b 
(cherry picked from commit 94ea1c2)
@matthewbauer matthewbauer requested review from edolstra, alyssais and grahamc and removed request for edolstra and alyssais March 8, 2019 22:56
@grahamc
Copy link
Member

grahamc commented Mar 9, 2019

@GrahamcOfBorg build nix

@grahamc
Copy link
Member

grahamc commented Mar 9, 2019

I'm not so sure. I think the intention was the minor bumps would be for the new release. I'd want @edolstra's opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthewbauer @grahamc @infinisil @GrahamcOfBorg @edolstra