Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: backport hunspell 1.7.0 support from upstream #57237

Merged
merged 1 commit into from Mar 29, 2019
Merged

emacs: backport hunspell 1.7.0 support from upstream #57237

merged 1 commit into from Mar 29, 2019

Conversation

vlaci
Copy link
Contributor

@vlaci vlaci commented Mar 10, 2019

Motivation for this change

NixOS 19.03 has hunspell 1.7.0 which is incompatible with emacs 26.1.
This issue has been fixed in upstream and we should drop this patch
after emacs is updated too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

emacs: backport hunspell 1.7.0 support from upstream
4952378 
NixOS 19.03 has hunspell 1.7.0 which is incompatible with emacs 26.1.
This issue has been fixed in upstream and we should drop this patch
after emacs is updated too.
@hedning
Copy link
Contributor

hedning commented Mar 10, 2019

@GrahamcOfBorg build emacs

@vlaci
Copy link
Contributor Author

vlaci commented Mar 29, 2019 •
edited

Hi,
What could I do to get this PR merged?

@dywedir
Copy link
Member

dywedir commented Mar 29, 2019

Thanks @vlaci!

@dywedir dywedir merged commit 60ec578 into NixOS:master Mar 29, 2019
@benley benley mentioned this pull request May 1, 2019
Merged
10 tasks
@vlaci vlaci deleted the pkgs/emacs branch August 5, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

@jwiegley jwiegley Awaiting requested review from jwiegley

@peti peti Awaiting requested review from peti

@lovek323 lovek323 Awaiting requested review from lovek323

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vlaci @hedning @dywedir @GrahamcOfBorg