Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: format the documentation #57102

Merged
merged 2 commits into from Mar 9, 2019
Merged

doc: format the documentation #57102

merged 2 commits into from Mar 9, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Mar 9, 2019 •
edited

Motivation for this change

Format the documentation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit kalbasit changed the title Nixpkgs format doc doc: format the documentation Mar 9, 2019
@kalbasit kalbasit requested a review from grahamc March 9, 2019 02:28
@grahamc
Copy link
Member

grahamc commented Mar 9, 2019 •
edited

@GrahamcOfBorg eval

@grahamc
Copy link
Member

grahamc commented Mar 9, 2019 via email

@kalbasit kalbasit merged commit a7f4fd0 into NixOS:master Mar 9, 2019
@kalbasit
Copy link
Member Author

kalbasit commented Mar 9, 2019

Thanks @grahamc!

@kalbasit kalbasit deleted the nixpkgs_format-doc branch March 9, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @grahamc @GrahamcOfBorg