Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dnslib: init at 0.9.9 #57101

Merged
merged 1 commit into from Mar 25, 2019
Merged

pythonPackages.dnslib: init at 0.9.9 #57101

merged 1 commit into from Mar 25, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Mar 9, 2019

Motivation for this change

New package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth delroth requested a review from FRidh as a code owner March 9, 2019 02:14
@dotlambda dotlambda changed the title pythonPackages.dnslib,python3Packages.dnslib: init at 0.9.8 pythonPackages.dnslib: init at 0.9.8 Mar 23, 2019
@delroth delroth force-pushed the python-dnslib branch 2 times, most recently from 87cb373 to d916f90 Compare March 24, 2019 10:41
@delroth delroth changed the title pythonPackages.dnslib: init at 0.9.8 pythonPackages.dnslib: init at 0.9.9 Mar 24, 2019
dotlambda
dotlambda requested changes Mar 24, 2019
View reviewed changes
pkgs/development/python-modules/dnslib/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/dnslib/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/dnslib/default.nix Outdated Show resolved Hide resolved
@delroth
Copy link
Contributor Author

delroth commented Mar 25, 2019

Fixed and tested with PyPy while at it.

@GrahamcOfBorg build python2Packages.dnslib python3Packages.dnslib pypyPackages.dnslib

@dotlambda dotlambda merged commit 6beffff into NixOS:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @dotlambda @GrahamcOfBorg