Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] Sage python upgrade fixes #57253

Merged
merged 3 commits into from Mar 10, 2019
Merged

[19.03] Sage python upgrade fixes #57253

merged 3 commits into from Mar 10, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 10, 2019

Motivation for this change

Backport of #56781

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
sage: fix strictDeps fallout
d5230eb 
See NixOS#54182 and
NixOS#55757.

(cherry picked from commit 9e37547)
@timokau
python.pkgs.rpy2: fix strictDeps fallout
de9921e 
See NixOS#54182 and
NixOS#55757.

(cherry picked from commit c6e4e1d)
@timokau
sage: patch for pip 19
64c1b93 
pip 19 introduced a deprecation warning for python 2.7. Since sage
internally uses pip to query for installed packages, this deprecation
warning will show up at unexpected times. That is ugly and messes with
the testsuite.

Upstream: https://trac.sagemath.org/ticket/27405
(cherry picked from commit 2de81ee)
@timokau timokau requested a review from FRidh as a code owner March 10, 2019 14:59
@timokau timokau mentioned this pull request Mar 10, 2019
Merged
10 tasks
@timokau timokau merged commit 72ad05b into NixOS:release-19.03 Mar 10, 2019
@timokau timokau deleted the sage-python-upgrade-fixes-19.03 branch March 10, 2019 15:19
@strager strager mentioned this pull request Mar 11, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg