Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf: 3.6 -> 3.7 #57181

Merged
merged 3 commits into from Apr 14, 2019
Merged

protobuf: 3.6 -> 3.7 #57181

merged 3 commits into from Apr 14, 2019

Conversation

FlorianFranzen
Copy link
Contributor

Motivation for this change

Adds and switches to protobuf version 3.7.

Also updates protobuf 3.6.1 to 3.6.1.3.

A few of the derivates in nox-review fail because of issues not related to this update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda removed the request for review from orivej-nixos April 5, 2019 08:33
@dotlambda
Copy link
Member

cc @orivej

@dotlambda
Copy link
Member

@FlorianFranzen I promise I won't merge my own PR this time. Still, it would be nice if you could try my recommended change.

@dotlambda
Copy link
Member

Now we can also build python3.pkgs.protobuf.override { protobuf = protobuf3_5; }.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orivej I think this is ready for merge.

@dotlambda dotlambda merged commit 90d166d into NixOS:master Apr 14, 2019
@FlorianFranzen
Copy link
Contributor Author

@dotlambda No hard feelings and sorry for my absence. Thank you for completing the pull request and getting it merged.

@FlorianFranzen FlorianFranzen deleted the protobuf branch April 25, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants