Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pysideTools: Use fetchFromGitHub and update meta #57108

Merged
merged 1 commit into from Apr 25, 2019
Merged

pythonPackages.pysideTools: Use fetchFromGitHub and update meta #57108

merged 1 commit into from Apr 25, 2019

Conversation

FlorianFranzen
Copy link
Contributor

Motivation for this change

Fixes build of the pysideTools python package. Without this patch, cmake will not be added to the path and the cmake hooks will fail to find and run cmake.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp
Copy link
Member

@GrahamcOfBorg build python2Packages.pysideTools python3Packages.pysideTools
Someone also please backport this to 19.03. #56826

@FlorianFranzen FlorianFranzen mentioned this pull request Mar 18, 2019
Closed
10 tasks
@worldofpeace
Copy link
Contributor

Btw, does anyone know why we still have the deprecated PySide and not PySide2?
I'd think we'd like to move away from it in nixpkgs.

@worldofpeace worldofpeace mentioned this pull request Mar 18, 2019
Closed
10 tasks
@FlorianFranzen FlorianFranzen changed the title pythonPackages.pysideTools: fix compilation pythonPackages.pysideTools: Maintenance update Apr 25, 2019
@FlorianFranzen
Copy link
Contributor Author

@worldofpeace Sorry for the absence. Fix was already merged with 6b8f800, so I rebased the patch to keep the other suggested changes.

@worldofpeace worldofpeace changed the title pythonPackages.pysideTools: Maintenance update pythonPackages.pysideTools: Use fetchFromGitHub and update meta Apr 25, 2019
@worldofpeace
Copy link
Contributor

@worldofpeace Sorry for the absence. Fix was already merged with 6b8f800, so I rebased the patch to keep the other suggested changes.

Sounds good.

@worldofpeace worldofpeace merged commit 5aa0475 into NixOS:master Apr 25, 2019
@worldofpeace
Copy link
Contributor

Thanks for the follow through in the end @FlorianFranzen ❇️

@FlorianFranzen FlorianFranzen deleted the pyside-tools branch April 26, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@knedlsepp knedlsepp knedlsepp approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FlorianFranzen @knedlsepp @worldofpeace @GrahamcOfBorg