Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, dates will be automatically switched to the user's timezone with JavaScript. Users without JavaScript enabled will have the previous behaviour, with the addition of a
title
which holds a fuller date, which also shows the timezone name. Additionally, relative times will always show more details in the title.The user-facing dates, when enhanced, also present an enhanced title test, here's an example:
The first line shows the user's timezone's offset, and also shows the date in UTC and hydra-local timezone.
Motivations
I have been burned by the hydra.nixos.org instance, assuming the dates were UTC, since there was no timezone label at all, and no setting available.
With this change, it is harder for an end-user to make bad assumptions about dates, EXCEPT for users which were used to timezone offsets. This is helped by introducing an underline to the dates, hoping the users then notice the cursor change and the title text.
Additionally, iconography could be added to try an better indicate the change, but I fear this would be too much.
Finally, relative dates haven't been touched. It could be possible to hook a live-updater to the relative times, but I don't want to introduce other third-party code. Making it ourselves could work, but for the investment of time (not that much) I'd prefer a clear go-ahead.
I think this fully addresses #393 cc @copumpkin